-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rem units for typography #1760
Conversation
Hey @robinmetral, Thanks! |
🦋 Changeset detectedLatest commit: ecbd4cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## next #1760 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 172 172
Lines 3526 3526
Branches 1177 1173 -4
=======================================
Hits 3230 3230
Misses 275 275
Partials 21 21
|
Closes #1679
Purpose
Switches typography units to rem, for accessibility reasons.
This change will ensure that text scales based on user font size settings.
This is a major (therefore targeting
next
) because apps will need to make sure they're not changing the default rem value (it should be 16px).This is how the Storybook looks when making font size "very large" on Chrome:
Approach and changes
Definition of done
Unit and integration tests