Allow passing custom aria-describedby values to form components #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e619bee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
robinmetral
changed the title
Codecov Report
@@ Coverage Diff @@
## next #1813 +/- ##
==========================================
- Coverage 91.85% 91.81% -0.04%
==========================================
Files 172 172
Lines 3534 3544 +10
Branches 1134 1139 +5
==========================================
+ Hits 3246 3254 +8
- Misses 268 270 +2
Partials 20 20
|
added 2 commits
October 26, 2022 11:42
…mponents Namely ImageInput, Input, RadioButtonGroup and Select
robinmetral
force-pushed
the
custom-aria-descriptions
branch
from
ebbfc91
to
e619bee
Compare
robinmetral
added
🐞 bug
robinmetral
commented
Oct 26, 2022
Comment on lines
+193
to
+195
| const descriptionIds = `${ | ||
| descriptionId ? `${descriptionId} ` : '' | ||
| }${validationHintId}`; |
There was a problem hiding this comment.
Couldn't think of anything cleaner here. But in the end I think it's pretty clear, and tests also document the reasoning behind this. Feedback welcome.
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #1795
Purpose
#1795 programatically associated input
validationHints with input elements usingaria-describedby.However, it overlooked the case where an implementation wants to pass multiple descriptions to
aria-describedby. In the current implementation, any custom id passed to the attribute would be overridden by the generated id of thevalidationHintelement.We're already running into this use case in Circuit UI itself, specifically in the
CurrencyInputcomponent, where the input needs to be described both by itsvalidationHintbut also by the currency suffix (otherwise the currency is left out of the accessibility properties of the input.Approach and changes
Combine the
validationHintId(generated internally) with any customaria-describedbyvalue (a list of ids, separated with spaces) passed to the component.Covered extensively with the awesome
@testing-librarymatchers 💙Definition of done