-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: interactive styles on secondary button inside a ButtonGroup #1938
Conversation
Hey @sirineJ, Thanks! |
🦋 Changeset detectedLatest commit: c68b717 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
a6aa77f
to
6b601c2
Compare
Codecov Report
@@ Coverage Diff @@
## main #1938 +/- ##
=======================================
Coverage 91.69% 91.69%
=======================================
Files 172 172
Lines 3565 3565
Branches 1198 1198
=======================================
Hits 3269 3269
Misses 275 275
Partials 21 21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this! 🙌
6b601c2
to
c68b717
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Fixes #1937
Purpose
Fix observed wrong styles on secondary action inside a
<ButtonGroup/>
Approach and changes
Override secondary button styles in the SecondaryButton
Definition of done