Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the design of the Toggle component #1983

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

connor-baer
Copy link
Member

Purpose

The Toggle's shadow is using a "hard" style for shadows which we don't have anywhere else. This has become especially noticeable with the new color tokens.

Approach and changes

  • Replace the Toggle's hard shadow with a soft one
  • Fix some of the disabled colors

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer requested a review from a team as a code owner March 10, 2023 09:21
@connor-baer connor-baer requested review from tareqlol and removed request for a team March 10, 2023 09:21
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2023

🦋 Changeset detected

Latest commit: da70306

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
oss-circuit-ui ✅ Ready (Inspect) Visit Preview Mar 10, 2023 at 9:21AM (UTC)

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #1983 (da70306) into main (71b11f8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1983      +/-   ##
==========================================
- Coverage   91.50%   91.49%   -0.01%     
==========================================
  Files         169      169              
  Lines        3521     3517       -4     
  Branches     1205     1205              
==========================================
- Hits         3222     3218       -4     
  Misses        279      279              
  Partials       20       20              
Impacted Files Coverage Δ
packages/circuit-ui/components/Toggle/Toggle.tsx 88.88% <ø> (ø)
...-ui/components/Toggle/components/Switch/Switch.tsx 84.61% <100.00%> (-2.06%) ⬇️

@connor-baer connor-baer merged commit e2bc1c8 into main Mar 10, 2023
@connor-baer connor-baer deleted the feature/toggle-design-tweaks branch March 10, 2023 09:35
@connor-baer connor-baer mentioned this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants