Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward refs to notification components #2007

Merged
merged 4 commits into from
Mar 20, 2023
Merged

Conversation

connor-baer
Copy link
Member

Fixes #1828.

Purpose

As a rule all components should forward refs to either the wrapping element (for patterns like notifications) or to the core HTML element (such as the input for inputs).

@robinmetral in #1828 (comment)

Approach and changes

  • Forward refs to the NotificationBanner, NotificationFullscreen, and NotificationInline components

I didn't add refs to the NotificationModal and NotificationToast components since those aren't rendered directly by developers.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label Mar 20, 2023
@connor-baer connor-baer requested a review from a team as a code owner March 20, 2023 09:29
@connor-baer connor-baer requested review from tareqlol and removed request for a team March 20, 2023 09:29
@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2023

🦋 Changeset detected

Latest commit: dbab04f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 20, 2023 at 9:33AM (UTC)

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #2007 (dbab04f) into main (7a71094) will increase coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2007   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files         170      170           
  Lines        3541     3543    +2     
  Branches     1176     1176           
=======================================
+ Hits         3256     3258    +2     
  Misses        265      265           
  Partials       20       20           
Impacted Files Coverage Δ
...mponents/NotificationBanner/NotificationBanner.tsx 83.87% <84.61%> (+0.26%) ⬆️
...mponents/NotificationInline/NotificationInline.tsx 92.98% <88.88%> (+0.12%) ⬆️
.../NotificationFullscreen/NotificationFullscreen.tsx 100.00% <100.00%> (ø)

Copy link
Contributor

@robinmetral robinmetral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@connor-baer connor-baer changed the title Forward refs to notification components Forward refs to notification components (#2007 Mar 20, 2023
@connor-baer connor-baer merged commit 8ab8c20 into main Mar 20, 2023
@connor-baer connor-baer deleted the bugfix/notification-refs branch March 20, 2023 10:29
@connor-baer connor-baer mentioned this pull request Mar 20, 2023
@connor-baer connor-baer changed the title Forward refs to notification components (#2007 Forward refs to notification components Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should 🗂 circuit-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ref is not forwarded to the DOM element in the NotificationInline component
2 participants