-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward refs to notification components #2007
Conversation
🦋 Changeset detectedLatest commit: dbab04f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #2007 +/- ##
=======================================
Coverage 91.95% 91.95%
=======================================
Files 170 170
Lines 3541 3543 +2
Branches 1176 1176
=======================================
+ Hits 3256 3258 +2
Misses 265 265
Partials 20 20
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes #1828.
Purpose
– @robinmetral in #1828 (comment)
Approach and changes
ref
s to the NotificationBanner, NotificationFullscreen, and NotificationInline componentsI didn't add
ref
s to the NotificationModal and NotificationToast components since those aren't rendered directly by developers.Definition of done