Account for scrollbar in expanded SideNavigation #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5386712 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Marczerwinski
approved these changes
May 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #2123 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 170 170
Lines 3571 3571
Branches 1248 1248
=======================================
Hits 3287 3287
Misses 263 263
Partials 21 21
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a Slack thread.
Purpose
The SideNavigation is supposed to be fully expanded on viewports wider than 1920px. This can cause a flicker on monitors that measure exactly 1920px since the viewport size is reduced by the scrollbar which is present on most pages. When opening a modal, the page content is locked in place, so the scroll bar disappears and the side navigation is expanded.
Approach and changes
Definition of done