feat: add a helper text to radio buttons options #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 61fcdf2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sirineJ
force-pushed
the
feat/add-helper-text-to-radio-buttons
branch
from
3082b75
to
c93f712
Compare
connor-baer
requested changes
Jul 21, 2023
There was a problem hiding this comment.
Thank you for suggesting and implementing this improvement, @sirineJ! 🙌
I've left several suggestions to align the implementation with similar components in the design system. Let me know if you'd like to make the changes yourself or if you'd like me to continue from here.
packages/circuit-ui/components/RadioButton/RadioButton.spec.tsx
Outdated
Show resolved
Hide resolved
packages/circuit-ui/components/RadioButton/RadioButton.spec.tsx
Outdated
Show resolved
Hide resolved
sirineJ
force-pushed
the
feat/add-helper-text-to-radio-buttons
branch
from
c93f712
to
0860dde
Compare
sirineJ
force-pushed
the
feat/add-helper-text-to-radio-buttons
branch
from
0860dde
to
f43e426
Compare
sirineJ
force-pushed
the
feat/add-helper-text-to-radio-buttons
branch
from
f43e426
to
b2d2cf2
Compare
sirineJ
force-pushed
the
feat/add-helper-text-to-radio-buttons
branch
from
b2d2cf2
to
222a076
Compare
sirineJ
force-pushed
the
feat/add-helper-text-to-radio-buttons
branch
from
222a076
to
33baf90
Compare
sirineJ
force-pushed
the
feat/add-helper-text-to-radio-buttons
branch
from
33baf90
to
87a565a
Compare
sirineJ
force-pushed
the
feat/add-helper-text-to-radio-buttons
branch
from
87a565a
to
8bf456a
Compare
Codecov Report
@@ Coverage Diff @@
## main #2191 +/- ##
==========================================
+ Coverage 92.09% 92.10% +0.01%
==========================================
Files 171 171
Lines 3607 3612 +5
Branches 1270 1275 +5
==========================================
+ Hits 3322 3327 +5
Misses 264 264
Partials 21 21
|
connor-baer
reviewed
Jul 25, 2023
There was a problem hiding this comment.
Thanks for accepting my suggestions. This is looking great! 👏
Could you please add a changeset to summarize the change for the changelog?
sirineJ
force-pushed
the
feat/add-helper-text-to-radio-buttons
branch
from
8bf456a
to
b638575
Compare
sirineJ
force-pushed
the
feat/add-helper-text-to-radio-buttons
branch
from
b638575
to
85cb842
Compare
connor-baer
reviewed
Jul 25, 2023
connor-baer
approved these changes
Jul 25, 2023
sirineJ
force-pushed
the
feat/add-helper-text-to-radio-buttons
branch
from
a18379e
to
a97d9c5
Compare
connor-baer
approved these changes
Jul 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2190.
Purpose
Display optional helper text beneath a radio input's label
Definition of done