Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect SearchInput padding #2222

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Conversation

a5e
Copy link
Contributor

@a5e a5e commented Aug 22, 2023

Purpose

Remove the padding due to passing a function to Input prop renderSuffix.

Approach and changes

Use optional spreading to only pass the prop when needed.

Before:
Screenshot 2023-08-22 at 14 32 06

After:
Screenshot 2023-08-22 at 14 31 33

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@a5e a5e self-assigned this Aug 22, 2023
@a5e a5e requested a review from a team as a code owner August 22, 2023 12:40
@a5e a5e requested review from pdrmdrs and removed request for a team August 22, 2023 12:40
@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2023

🦋 Changeset detected

Latest commit: 181d79e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 1:45pm

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #2222 (181d79e) into main (b3e7e25) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2222   +/-   ##
=======================================
  Coverage   97.04%   97.04%           
=======================================
  Files         251      251           
  Lines       19631    19636    +5     
  Branches     1180     1180           
=======================================
+ Hits        19051    19056    +5     
  Misses        576      576           
  Partials        4        4           
Files Changed Coverage Δ
.../circuit-ui/components/SearchInput/SearchInput.tsx 88.88% <100.00%> (+0.59%) ⬆️

@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label Aug 22, 2023
Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this fix!

@connor-baer connor-baer merged commit 3deeb5c into main Aug 22, 2023
10 checks passed
@connor-baer connor-baer deleted the remove-phantom-suffix-padding branch August 22, 2023 14:21
@connor-baer connor-baer mentioned this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should 🗂 circuit-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants