Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen SelectorGroup's icon prop type #2239

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Widen SelectorGroup's icon prop type #2239

merged 2 commits into from
Sep 6, 2023

Conversation

connor-baer
Copy link
Member

Improves #2238.

Purpose

#2238 added support for icons inside SelectorGroup options. Currently, the prop type only allows icons from @sumup/icons, but small images or illustrations should be supported as well.

Approach and changes

  • Widen the prop type for the SelectorGroup's icon prop

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer requested a review from a team as a code owner September 6, 2023 09:41
@connor-baer connor-baer requested review from pdrmdrs and removed request for a team September 6, 2023 09:41
@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2023

🦋 Changeset detected

Latest commit: fc7f12d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 9:53am

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #2239 (fc7f12d) into main (de7489b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2239   +/-   ##
=======================================
  Coverage   97.04%   97.04%           
=======================================
  Files         251      251           
  Lines       19806    19806           
  Branches     1208     1208           
=======================================
  Hits        19220    19220           
  Misses        566      566           
  Partials       20       20           
Files Changed Coverage Δ
...ckages/circuit-ui/components/Selector/Selector.tsx 96.90% <100.00%> (ø)

@connor-baer connor-baer merged commit 3b8933f into main Sep 6, 2023
13 of 14 checks passed
@connor-baer connor-baer deleted the fix/icon-prop-type branch September 6, 2023 10:02
@connor-baer connor-baer mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants