Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Button's loading label #2247

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Hide Button's loading label #2247

merged 2 commits into from
Sep 11, 2023

Conversation

connor-baer
Copy link
Member

Purpose

The Button's loading label is hidden from the accessibility tree using CSS (visibility: hidden). Switching to CSS Modules means that these styles are no longer serialized in a JSDOM environment, leading @testing-library/react to consider the element as visible.

Approach and changes

  • Hide the loading label using the aria-hidden HTML attribute when not loading

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer requested a review from a team as a code owner September 11, 2023 19:34
@connor-baer connor-baer requested review from tareqlol and removed request for a team September 11, 2023 19:34
@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2023

🦋 Changeset detected

Latest commit: bcdfc57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2023 7:36pm

@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #2247 (bcdfc57) into main (7a0eeff) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2247   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files         251      251           
  Lines       19822    19826    +4     
  Branches     1211     1211           
=======================================
+ Hits        19230    19234    +4     
  Misses        572      572           
  Partials       20       20           
Files Changed Coverage Δ
packages/circuit-ui/components/Button/Button.tsx 93.18% <100.00%> (+0.15%) ⬆️

@connor-baer connor-baer merged commit 390d1e4 into main Sep 11, 2023
13 of 14 checks passed
@connor-baer connor-baer deleted the fix/button-loading-label branch September 11, 2023 19:54
@connor-baer connor-baer mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should 🗂 circuit-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant