Fix style specificity conflicts #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7d236f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
connor-baer
force-pushed
the
fix/style-specificity
branch
from
e10dd3d
to
c4a9193
Compare
Codecov Report
@@ Coverage Diff @@
## main #2249 +/- ##
=======================================
Coverage 97.01% 97.01%
=======================================
Files 251 251
Lines 19826 19833 +7
Branches 1211 1211
=======================================
+ Hits 19234 19241 +7
Misses 572 572
Partials 20 20
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Vite's CSS ordering appears broken (vitejs/vite#11662, vitejs/vite#4890, vitejs/vite#7504). The order of the styles in the single CSS file that Vite outputs does not match the import order (or any other discernable order, for that matter). CSS order matters because between style rules with the same specificity, the last one wins.
Approach and changes
Definition of done