Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style SearchInput clear icon #2254

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

tareqlol
Copy link
Contributor

Purpose

The SearchInput clear icon styles were not applied, due to the icon being suffixed next to the input element.
image

Approach and changes

Fixes the CSS rule for that icon

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@tareqlol tareqlol added the 🐞 bug Something isn't working as it should label Sep 22, 2023
@tareqlol tareqlol requested a review from a team as a code owner September 22, 2023 10:03
@tareqlol tareqlol requested review from pdrmdrs and removed request for a team September 22, 2023 10:03
@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2023

🦋 Changeset detected

Latest commit: 29f5cf0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview Sep 22, 2023 10:03am

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #2254 (29f5cf0) into main (4f08012) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2254   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files         251      251           
  Lines       19833    19833           
  Branches     1211     1211           
=======================================
  Hits        19241    19241           
  Misses        572      572           
  Partials       20       20           

@tareqlol tareqlol merged commit 17a9bcb into main Sep 22, 2023
14 checks passed
@tareqlol tareqlol deleted the fix/search-input-clear-icon-style branch September 22, 2023 10:12
@connor-baer connor-baer mentioned this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should 🗂 circuit-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant