Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Selector component size padding #2255

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Conversation

tareqlol
Copy link
Contributor

@tareqlol tareqlol commented Sep 25, 2023

Purpose

The Selector component uses incorrect padding custom variables for kilo and mega.
The Selector description does not wrap

Approach and changes

  • Adjust the padding to the size that correlates with the passed size property.
  • Adjust the description to wrap.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@tareqlol tareqlol requested a review from a team as a code owner September 25, 2023 09:15
@tareqlol tareqlol requested review from pdrmdrs and removed request for a team September 25, 2023 09:15
@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

🦋 Changeset detected

Latest commit: cc49ae6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 9:52am

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #2255 (cc49ae6) into main (e2f8230) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2255   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files         251      251           
  Lines       19833    19835    +2     
  Branches     1211     1211           
=======================================
+ Hits        19241    19243    +2     
  Misses        572      572           
  Partials       20       20           
Files Coverage Δ
...ckages/circuit-ui/components/Selector/Selector.tsx 96.93% <100.00%> (+0.03%) ⬆️

@tareqlol tareqlol merged commit 600eff2 into main Sep 26, 2023
12 of 14 checks passed
@tareqlol tareqlol deleted the fix/selector-component-paddings branch September 26, 2023 10:00
@connor-baer connor-baer mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant