Increase IconButton CSS specificity #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fbce4e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tareqlol
force-pushed
the
fix/icon-button-paddings
branch
from
b804207
to
74468c6
Compare
tareqlol
changed the title
tareqlol
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2264 +/- ##
=======================================
Coverage 97.01% 97.01%
=======================================
Files 251 251
Lines 19841 19841
Branches 1211 1211
=======================================
Hits 19249 19249
Misses 572 572
Partials 20 20 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #ticket-number.
Purpose
IconButtonsizes CSS rules are overwritten by the Button size rules, causing the Icon button to have Button padding instead of the IconButton padding.Approach and changes
Increases the IconButton size rules by a weight of 1.
Definition of done