Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new icon InterestOnBalance in size 24. #2278

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

giedoka
Copy link
Contributor

@giedoka giedoka commented Oct 19, 2023

Addresses #ticket-number.

Purpose

Added new icon InterestOfBalance in size 24.

Approach and changes

Exported and optimized the svgs from Figma.
Updated the manifest.
Created a changeset.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@giedoka giedoka requested a review from a team as a code owner October 19, 2023 12:00
@giedoka giedoka requested review from pdrmdrs and removed request for a team October 19, 2023 12:00
@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023

🦋 Changeset detected

Latest commit: 58ebd93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@sumup/icons Minor
@sumup/circuit-ui Major
@sumup/eslint-plugin-circuit-ui Major
@sumup/remix-template-circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 7:33am

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #2278 (58ebd93) into main (191885b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2278   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files         251      251           
  Lines       19841    19841           
  Branches     1211     1211           
=======================================
  Hits        19249    19249           
  Misses        572      572           
  Partials       20       20           

@@ -986,6 +986,11 @@
"category": "Finance",
"size": "24"
},
{
"name": "interest_of_balance",
Copy link
Contributor

@Burtchen Burtchen Oct 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is 'interest of balance' supposed to be? The Google Search for it does not yield anything plausible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops... Thank you for pointing the typo 😅

.changeset/chatty-pears-admire.md Outdated Show resolved Hide resolved
packages/icons/manifest.json Outdated Show resolved Hide resolved
packages/icons/web/v2/interest_of_balance_24.svg Outdated Show resolved Hide resolved
Copy link
Contributor

@Burtchen Burtchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📊

@giedoka giedoka merged commit b2edba6 into main Oct 20, 2023
14 checks passed
@giedoka giedoka deleted the feature/new-interest-of-balance-icon branch October 20, 2023 07:45
@connor-baer connor-baer mentioned this pull request Oct 20, 2023
@connor-baer connor-baer changed the title Added new icon InterestOfBalance in size 24. Added new icon InterestOnBalance in size 24. Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants