Fix the size of icons in Buttons #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5e17ccb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2330 +/- ##
=======================================
Coverage 96.93% 96.93%
=======================================
Files 251 251
Lines 20162 20162
Branches 1246 1246
=======================================
Hits 19545 19545
Misses 605 605
Partials 12 12 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Before #2307, developers would pass icons as a child React Element to the IconButton component, which meant they could manually specify the icon size. Now, the icon component is passed directly as a prop, and the icon size is configured internally based on the Button's size: A small Button uses a 16px icon, and a medium Button uses a 24px icon.
Often, an icon is only available in one size that might not match the size the Button expects. The icon is up or downscaled as a workaround, and a warning is logged. Or at least it should be scaled — this is currently broken.
Approach and changes
Definition of done