Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate long Button labels #2352

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Truncate long Button labels #2352

merged 1 commit into from
Dec 21, 2023

Conversation

connor-baer
Copy link
Member

Purpose

The design team insists that truncating long Button labels when they overflow their container is better than letting the text wrap 🤷🏻

Before

Screenshot 2023-12-21 at 11 25 42

After

Screenshot 2023-12-21 at 11 25 26

Approach and changes

  • Changed the overflow behaviour of long Button labels. Text that would previously wrap is now truncated to a single line with a trailing ellipsis.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer requested a review from a team as a code owner December 21, 2023 10:30
Copy link

changeset-bot bot commented Dec 21, 2023

🦋 Changeset detected

Latest commit: 6138829

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sumup/circuit-ui Major
@sumup/eslint-plugin-circuit-ui Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview Dec 21, 2023 10:30am

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c2c3376) 96.97% compared to head (6138829) 96.97%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           canary    #2352   +/-   ##
=======================================
  Coverage   96.97%   96.97%           
=======================================
  Files         252      252           
  Lines       20273    20273           
  Branches     1263     1263           
=======================================
  Hits        19660    19660           
  Misses        600      600           
  Partials       13       13           

@connor-baer connor-baer merged commit 08aa962 into canary Dec 21, 2023
14 checks passed
@connor-baer connor-baer deleted the feature/truncate-buttons branch December 21, 2023 16:16
@connor-baer connor-baer mentioned this pull request Jan 10, 2024
@connor-baer connor-baer mentioned this pull request May 7, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant