Prefer web safe fonts over system fonts #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 82c9700 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2416 +/- ##
==========================================
+ Coverage 96.77% 96.79% +0.01%
==========================================
Files 229 229
Lines 19037 19037
Branches 1185 1185
==========================================
+ Hits 18424 18426 +2
+ Misses 600 598 -2
Partials 13 13
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
A bug in Chrome causes bold text rendered using the system font on macOS to be extra thick. The bug has supposedly been fixed, but can still be reproduced with bold & italic text.
The bug is present when any of the
-apple-system,BlinkMacSystemFont, orsystem-uifonts are used. Removing these causes Chrome on macOS to fallback to Helvetica. This prompted the idea to move Helvetica and Arial before the system fonts as this provides a more consistent user experience across platforms and reduces layout shift when switching to SumUp's brand font, Aktiv Grotesk.The system fonts are kept in the font stack in case certain characters aren't available in any of the previous fonts. The same reasoning applies to the emoji and symbol fonts.
Approach and changes
Definition of done