Adjust shadows and gradients for dark mode #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 849fbdb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2433 +/- ##
==========================================
- Coverage 96.79% 96.78% -0.01%
==========================================
Files 229 229
Lines 19037 19040 +3
Branches 1184 1185 +1
==========================================
+ Hits 18426 18427 +1
- Misses 598 600 +2
Partials 13 13
|
The `color-mix` function isn't supported in all target browsers, however, the overflow indicator is arguably a progressive enhancement and not essential to the user experience.
connor-baer
force-pushed
the
fix/dark-mode
branch
from
3a37ebe
to
849fbdb
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The experimental dark mode has surfaced some bugs in how color tokens are used in the components and highlighted some hard-coded color values.
Approach and changes
color-mixfunction isn't supported in all target browsers; however, the overflow indicator is arguably a progressive enhancement and not essential to the user experience.Definition of done