Rename Table's initialSortedRow to initialSortedColumn #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 577f712 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2491 +/- ##
=======================================
Coverage 87.68% 87.69%
=======================================
Files 198 198
Lines 21209 21221 +12
Branches 1281 1285 +4
=======================================
+ Hits 18597 18609 +12
Misses 2560 2560
Partials 52 52
|
connor-baer
reviewed
Apr 15, 2024
connor-baer
approved these changes
Apr 15, 2024
connor-baer
changed the title
connor-baer
deleted the
bugfix/change-initialsortedrow-to-initialsortedcolumn
branch
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered during the implementation of other table-related functionalities: The language/variables sometimes confuse row for column, which... well, it's confusing. Let's fix that.
I went for a straightforward change (instead of a deprecation) in the TableHead component. While it is exposed, none of the internal projects seem to use it and our Storybook also does not showcase it as a 'proper' component.
For the Table itself, the
initialSortedRowprop is now deprecated in lieu ofinitialSortedColumnDefinition of done