Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automatic balance transfer icon #2495

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Add Automatic balance transfer icon #2495

merged 5 commits into from
Apr 26, 2024

Conversation

pspasova
Copy link
Contributor

@pspasova pspasova commented Apr 22, 2024

Addresses BPA-1997

Purpose

Add AutomaticBalanceTransfer button which is going to be used for the balance forwarding feature.

@pspasova pspasova requested a review from a team as a code owner April 22, 2024 12:25
@pspasova pspasova requested review from connor-baer and removed request for a team April 22, 2024 12:25
Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: a5b0d31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@sumup/icons Minor
@sumup/circuit-ui Major
@sumup/astro-template-circuit-ui Patch
@sumup/eslint-plugin-circuit-ui Major
@sumup/remix-template-circuit-ui Patch
next-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 3:03pm

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.70%. Comparing base (482b935) to head (a5b0d31).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2495   +/-   ##
=======================================
  Coverage   87.70%   87.70%           
=======================================
  Files         198      198           
  Lines       21252    21252           
  Branches     1285     1285           
=======================================
  Hits        18640    18640           
  Misses       2560     2560           
  Partials       52       52           

Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to find the icon in the Figma library. Please make sure the icon is added there first and review the icon contribution guidelines to ensure that the SVG meets all requirements.

.changeset/brave-lamps-hammer.md Outdated Show resolved Hide resolved
packages/icons/manifest.json Outdated Show resolved Hide resolved
packages/icons/web/v2/forward_24.svg Outdated Show resolved Hide resolved
packages/icons/web/v2/forward_24.svg Outdated Show resolved Hide resolved
@pspasova pspasova changed the title Add Forward icon Add Automatic balance transfer icon Apr 26, 2024
@pspasova
Copy link
Contributor Author

I wasn't able to find the icon in the Figma library. Please make sure the icon is added there first and review the icon contribution guidelines to ensure that the SVG meets all requirements.

@connor-baer done ✔️ it was added by another name and under another category

Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! ⭐

@pspasova pspasova merged commit 7c74b3b into main Apr 26, 2024
14 checks passed
@pspasova pspasova deleted the feat/forward-icon branch April 26, 2024 15:14
@connor-baer connor-baer mentioned this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants