Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the updated Button styles #2551

Merged
merged 9 commits into from
Jul 9, 2024
Merged

Tweak the updated Button styles #2551

merged 9 commits into from
Jul 9, 2024

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented May 23, 2024

Addresses #ticket-number.

Purpose

After implementing the new button, we received feedback from multiple teams on different aspects of the component.

Approach and changes

  • Normalized the border-radius to 8px for all sizes.
  • Removed the horizontal padding of the tertiary variant and improved the color contrast its underline.
  • Updated the disabled styles to distinguish the button variants.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 4:29pm

Copy link

changeset-bot bot commented May 23, 2024

🦋 Changeset detected

Latest commit: 243dd36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@sumup/circuit-ui Major
@sumup/design-tokens Minor
@sumup/eslint-plugin-circuit-ui Major
@sumup/stylelint-plugin-circuit-ui Major
@sumup/astro-template-circuit-ui Patch
@sumup/remix-template-circuit-ui Patch
next-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.30%. Comparing base (0e76c53) to head (a1a5efb).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2551   +/-   ##
=======================================
  Coverage   88.30%   88.30%           
=======================================
  Files         206      206           
  Lines       22813    22819    +6     
  Branches     1527     1528    +1     
=======================================
+ Hits        20144    20150    +6     
  Misses       2617     2617           
  Partials       52       52           
Files Coverage Δ
packages/circuit-ui/components/Button/Button.tsx 88.67% <100.00%> (+0.67%) ⬆️
.../circuit-ui/components/ButtonGroup/ButtonGroup.tsx 89.47% <100.00%> (ø)
packages/design-tokens/themes/dark.ts 100.00% <100.00%> (ø)
packages/design-tokens/themes/light.ts 100.00% <100.00%> (ø)

@connor-baer connor-baer marked this pull request as ready for review July 4, 2024 14:56
@connor-baer connor-baer requested a review from a team as a code owner July 4, 2024 14:56
@connor-baer connor-baer changed the base branch from main to canary July 9, 2024 16:31
@connor-baer connor-baer merged commit d2115fb into canary Jul 9, 2024
8 of 12 checks passed
@connor-baer connor-baer deleted the feature/buttons-2.1 branch July 9, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant