feat: Update NotificationToast provider with position and className props #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: e88777e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2577 +/- ##
=======================================
Coverage 88.16% 88.16%
=======================================
Files 204 204
Lines 22320 22331 +11
Branches 1490 1490
=======================================
+ Hits 19678 19689 +11
Misses 2590 2590
Partials 52 52
|
voronianski
changed the title
voronianski
changed the title
connor-baer
reviewed
Jun 13, 2024
packages/circuit-ui/components/ToastContext/ToastContext.module.css
Outdated
Show resolved
Hide resolved
packages/circuit-ui/components/NotificationToast/NotificationToast.stories.tsx
Outdated
Show resolved
Hide resolved
packages/circuit-ui/components/NotificationToast/NotificationToast.mdx
Outdated
Show resolved
Hide resolved
packages/circuit-ui/components/NotificationToast/NotificationToast.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Connor Bär <connor-baer@users.noreply.github.com>
Co-authored-by: Connor Bär <connor-baer@users.noreply.github.com>
Co-authored-by: Connor Bär <connor-baer@users.noreply.github.com>
connor-baer
approved these changes
Jun 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses WPS-207.
Purpose
In certain applications (e.g. shop or marketing website) it's necessary to change the placement of NotificationToast (e.g. put it closer to shopping cart). Unfortunately current implementation displays NotificationToasts only at the bottom of a page. This PR extends NotificationToast position possibilities by providing a prop that can place NotificationToast at the top and at the top right corner of a page.
Approach and changes
positionprop toToastProviderwithbottom,topandtop-rightas possible values (usebottomas default value)classNameprop toToastProviderto allow slight modifications (e.g. using bigger CSS space variable for a position)Definition of done