Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(circuit-ui): Add experimental ColorInput component #2655

Merged
merged 8 commits into from
Sep 9, 2024

Conversation

matoous
Copy link
Contributor

@matoous matoous commented Aug 23, 2024

[Work in progress]

Add experimental ColorInput component.

Screenshot 2024-08-23 at 09 33 54 Screenshot 2024-08-23 at 09 34 10

Purpose

Describe what you are trying to accomplish

Approach and changes

Describe how you solved the problem

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 3:06pm

Copy link

changeset-bot bot commented Aug 23, 2024

🦋 Changeset detected

Latest commit: ae78968

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sumup/circuit-ui Minor
@sumup/eslint-plugin-circuit-ui Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 90.43478% with 11 lines in your changes missing coverage. Please review.

Project coverage is 86.63%. Comparing base (04a7016) to head (ae78968).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...es/circuit-ui/components/ColorInput/ColorInput.tsx 90.43% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2655      +/-   ##
==========================================
+ Coverage   86.59%   86.63%   +0.03%     
==========================================
  Files         209      210       +1     
  Lines       11885    12000     +115     
  Branches     1500     1506       +6     
==========================================
+ Hits        10292    10396     +104     
- Misses       1540     1551      +11     
  Partials       53       53              
Files with missing lines Coverage Δ
packages/circuit-ui/components/Input/Input.tsx 92.78% <ø> (ø)
...es/circuit-ui/components/ColorInput/ColorInput.tsx 90.43% <90.43%> (ø)

@matoous matoous force-pushed the md/color-input branch 2 times, most recently from a235be9 to 897e526 Compare September 8, 2024 13:44
@matoous
Copy link
Contributor Author

matoous commented Sep 8, 2024

Updated based on latest design proposal from Joao:
Screenshot 2024-09-08 at 15 45 14
Screenshot 2024-09-08 at 15 45 24
Screenshot 2024-09-08 at 15 45 38
Screenshot 2024-09-08 at 15 45 55

Co-authored-by: Connor Bär <connor-baer@users.noreply.github.com>
Importing the same CSS Module multiple times duplicates the styles and can cause specificity issues.
Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go as an experimental component. We'll need to iterate on the documentation and accessibility.

@connor-baer connor-baer changed the title feat(circuit-ui): ColorInput experimental component feat(circuit-ui): Add experimental ColorInput component Sep 9, 2024
@connor-baer connor-baer merged commit 5c62949 into main Sep 9, 2024
13 of 14 checks passed
@connor-baer connor-baer deleted the md/color-input branch September 9, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants