Add circle flag icons #2817
Open
Add circle flag icons #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 93a14d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +1.53 kB (+0.16%) Total Size: 972 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2817 +/- ##
=======================================
Coverage 87.54% 87.54%
=======================================
Files 217 217
Lines 12696 12697 +1
Branches 1723 1723
=======================================
+ Hits 11115 11116 +1
Misses 1528 1528
Partials 53 53
|
connor-baer
requested changes
Dec 10, 2024
There was a problem hiding this comment.
Hi Petya! The existing flags in the icon library only cover countries where SumUp operates and we've been aware of use cases that require more flags, such as the new PhoneNumberInput component or international bank transfers. So thank you for pushing this topic forward!
Unfortunately, we can't accept these proposed icons. Icons need to be added to the Figma icon library first before being implemented on web or mobile to ensure they're reviewed and follow our brand and icon guidelines. I checked with Suso, SumUp's icon designer, and he wasn't aware of these new flag icons. We identified several issues:
- While country flags generally don’t have a uniform shape — most are rectangular, but some are square — they’re never round.
- The existing flag icons have a thin grey outline to ensure flags with white elements remain distinguishable on a white background. New flags should follow the same pattern.
Please collaborate with Suso (Jesús Herrera on Slack) on finding a flag icon set that meets our icon guidelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #BPA-2269.
Purpose
I have temporarily added the flags directly in
ze-dashboardfor the Bulk Transfers initiative. I am now relocating them to their appropriate location. :)Approach and changes
Added all the flags and described them in manifest.json.