Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(configs): automatically deploy Storybook and Docz from CI #488

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

connor-baer
Copy link
Member

Fixes #487.

Purpose

Recent changes and fixes weren't deployed to GitHub Pages because the automatic deployment failed.

Approach and changes

  • Use npm package to deploy the GitHub Pages

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added 🐞 bug Something isn't working as it should 🛠️ tech Changes to the tech stack or infrastructure labels Oct 11, 2019
@connor-baer connor-baer added this to the v1.x milestone Oct 11, 2019
@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #488 into canary will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           canary     #488   +/-   ##
=======================================
  Coverage   76.15%   76.15%           
=======================================
  Files         167      167           
  Lines        2453     2453           
  Branches      435      435           
=======================================
  Hits         1868     1868           
  Misses        467      467           
  Partials      118      118

Copy link
Contributor

@fernandofleury fernandofleury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@connor-baer connor-baer merged commit abe5527 into canary Oct 14, 2019
@connor-baer connor-baer deleted the bugfix/automatic-deployment branch October 14, 2019 14:30
@ilyanoskov
Copy link
Contributor

🎉 This PR is included in version 1.2.2-canary.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ilyanoskov
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should 🛠️ tech Changes to the tech stack or infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Picture story is broken
3 participants