Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): pass href to NavItem link #492

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Oct 15, 2019

Follow up to #466.

Purpose

In the original PR, I forgot to pass the href through to the Link component in the NavItem.

Approach and changes

  • pass href to NavItem link
  • remove link underline

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added 🐞 bug Something isn't working as it should ready for review labels Oct 15, 2019
@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #492 into canary will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary     #492      +/-   ##
==========================================
+ Coverage   79.57%   79.59%   +0.01%     
==========================================
  Files         171      171              
  Lines        2473     2475       +2     
  Branches      444      445       +1     
==========================================
+ Hits         1968     1970       +2     
  Misses        388      388              
  Partials      117      117
Impacted Files Coverage Δ
...c/components/Sidebar/components/NavItem/NavItem.js 100% <ø> (ø) ⬆️
src/util/shared-prop-types.js 92.59% <ø> (ø) ⬆️
src/components/ButtonGroup/ButtonGroup.js 95% <100%> (+0.55%) ⬆️

@connor-baer connor-baer removed the request for review from robinmetral October 15, 2019 13:30
@connor-baer connor-baer merged commit d0bad70 into canary Oct 15, 2019
@connor-baer connor-baer deleted the bugfix/sidebar-links branch October 15, 2019 13:30
@ilyanoskov
Copy link
Contributor

🎉 This PR is included in version 1.2.2-canary.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ilyanoskov
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants