fix(components): prevent interactions on disabled Selector #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## canary #493 +/- ##
=======================================
Coverage 79.59% 79.59%
=======================================
Files 171 171
Lines 2475 2475
Branches 445 445
=======================================
Hits 1970 1970
Misses 388 388
Partials 117 117
|
connor-baer
changed the title
melissamoreira
approved these changes
Oct 15, 2019
|
🎉 This PR is included in version 1.2.2-canary.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When a Selector is disabled, it should no longer be interactive, i.e. the
onClickhandler should not fire.Approach and changes
pointer-events: noneDefinition of done