Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): prevent Storybook from overwriting the static CSS #505

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

connor-baer
Copy link
Member

Purpose

During the build process, Storybook was overwriting the static CSS file in the /dist folder.

Approach and changes

  • Build the static CSS file after the Storybook build has finished

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label Oct 30, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (canary@c203b43). Click here to learn what that means.
The diff coverage is n/a.

@connor-baer connor-baer merged commit 52e29ce into canary Oct 31, 2019
@connor-baer connor-baer deleted the bugfix/deploy-static-css branch October 31, 2019 11:07
@connor-baer
Copy link
Member Author

🎉 This PR is included in version 1.4.1-canary.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@connor-baer
Copy link
Member Author

🎉 This PR is included in version 2.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@connor-baer
Copy link
Member Author

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants