feat(components): migrate Text to TypeScript #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/ho8s60jpz |
Codecov Report
@@ Coverage Diff @@
## feature/typescript-jest #581 +/- ##
===========================================================
- Coverage 93.42% 93.37% -0.05%
===========================================================
Files 151 152 +1
Lines 2433 2431 -2
Branches 682 683 +1
===========================================================
- Hits 2273 2270 -3
- Misses 132 133 +1
Partials 28 28
|
fernandofleury
approved these changes
May 4, 2020
* test(configs): fix Jest config for TypeScript feature/typescript-jest feature/typescript-jest * docs: update test command feature/typescript-jest
feature/typescript-text
feature/typescript-text
feature/typescript-text feature/typescript-text
connor-baer
force-pushed
the
feature/typescript-text
branch
from
3b90057
to
3d2b9f3
Compare
|
🎉 This PR is included in version 2.0.0-alpha.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #516.
Purpose
I was testing #580 using the Text component.
Approach and changes
styledinstance to type thethemeas described in the Emotion docsText.KILO,Text.MEGA,Text.GIGA) since they're no longer needed with TypeScript and I couldn't figure out how to add types for themDefinition of done