Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate Heading to TypeScript #594

Merged
merged 2 commits into from
May 27, 2020
Merged

feat: migrate Heading to TypeScript #594

merged 2 commits into from
May 27, 2020

Conversation

robinmetral
Copy link
Contributor

Addresses #516.

Purpose

Migrate the Heading component to TypeScript.

Approach and changes

  • migrate Heading component to TypeScript
  • remove size exports (ex: Heading.GIGA). The size prop now expects a union of (lowercased) size strings. Instead of writing size={Heading.GIGA}, one would now write size="giga".

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

feat(components): migrate Heading to TypeScript
46eb398 
BREAKING CHANGE:
The Heading component doesn't export sizes anymore. Instead of writing `size={Heading.GIGA}`, write `size="giga"`.

feature/typescript-heading
@robinmetral robinmetral added the feature A new feature or enhancement label May 27, 2020
@robinmetral robinmetral added this to the v2.0 milestone May 27, 2020
@vercel
Copy link

vercel bot commented May 27, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/h0ishrl20
✅ Preview: https://circuit-ui-git-feature-typescript-heading.sumup-oss.now.sh

@sumup-clark
Copy link

sumup-clark bot commented May 27, 2020

Hey @robinmetral,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

@codecov
Copy link

codecov bot commented May 27, 2020 •
edited
Loading

Codecov Report

Merging #594 into alpha will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha     #594      +/-   ##
==========================================
- Coverage   94.24%   94.22%   -0.03%     
==========================================
  Files         137      137              
  Lines        2191     2183       -8     
  Branches      621      622       +1     
==========================================
- Hits         2065     2057       -8     
  Misses        103      103              
  Partials       23       23
Impacted Files Coverage Δ
src/components/Heading/Heading.tsx 100.00% <100.00%> (ø)
...onents/Modal/components/ModalHeader/ModalHeader.js 100.00% <100.00%> (ø)

connor-baer
connor-baer approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 💯

src/components/Heading/__snapshots__/Heading.spec.tsx.snap Outdated Show resolved Hide resolved
src/components/Heading/Heading.tsx Show resolved Hide resolved
connor-baer
connor-baer approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge it! 🚀

@robinmetral robinmetral merged commit 4675ef1 into alpha May 27, 2020
@robinmetral robinmetral deleted the feature/typescript-heading branch May 27, 2020 12:53
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0-alpha.20 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2020

🎉 This PR is included in version 2.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@herberthenrique herberthenrique mentioned this pull request Jun 9, 2020
Closed
49 tasks
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connor-baer connor-baer connor-baer approved these changes

@fernandofleury fernandofleury Awaiting requested review from fernandofleury

Assignees
No one assigned
Labels
feature A new feature or enhancement
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@robinmetral @connor-baer