chore(configs): compile JSX and add CJS output #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech/compile-jsx
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/854kgabb3 |
Codecov Report
@@ Coverage Diff @@
## alpha #597 +/- ##
=======================================
Coverage 94.25% 94.25%
=======================================
Files 137 137
Lines 2194 2194
Branches 621 621
=======================================
Hits 2068 2068
Misses 103 103
Partials 23 23 |
tech/compile-jsx tech/compile-jsx
connor-baer
force-pushed
the
tech/compile-jsx
branch
from
d9b87d0
to
738f90c
Compare
fernandofleury
approved these changes
May 31, 2020
|
🎉 This PR is included in version 2.0.0-alpha.21 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Tools such as create-react-app and create-next-app include
node_modulesin their transpilation process, however, they only transpile standard JavaScript. Thus, Circuit UI needs to precompile JSX, as it is a non-standard syntax.In addition, not all bundlers support ES module syntax. For those, I've added the CJS output format. Bundlers pick the best format that they support automatically based on the
mainandmoduleentries inpackage.json. This should make Circuit UI work out of the box in most cases.Approach and changes
jsxoption frompreservetoreactDefinition of done