feat(styles): load custom fonts #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature/load-fonts
feature/load-fonts
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/oqco64795 |
Codecov Report
@@ Coverage Diff @@
## alpha #603 +/- ##
==========================================
+ Coverage 94.22% 94.24% +0.01%
==========================================
Files 137 137
Lines 2183 2190 +7
Branches 622 622
==========================================
+ Hits 2057 2064 +7
Misses 103 103
Partials 23 23
|
fernandofleury
approved these changes
Jun 3, 2020
|
🎉 This PR is included in version 2.0.0-alpha.21 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When we started Circuit UI 2 years ago, I researched different font loading techniques. We decided to leave the font loading to the applications to give them the flexibility to control the loading behavior (FOIT vs FOUT etc). The ideal approach requires
<link />tags in the<head />, the API to inject those depends on the application (SSR and all). So we just documented it in Storybook.Nowadays, the
font-displayCSS property has decent browser support, so we can standardize it and automatically load the fonts.Approach and changes
font-facedeclarations to BaseStylesDefinition of done