feat(components): use smaller icons #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature/icons-16px feature/icons-16px feature/icons-16px
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/2xcjnjf5o |
Codecov Report
@@ Coverage Diff @@
## alpha #604 +/- ##
=======================================
Coverage 94.26% 94.26%
=======================================
Files 136 136
Lines 2198 2198
Branches 631 631
=======================================
Hits 2072 2072
Misses 103 103
Partials 23 23
|
fernandofleury
approved these changes
Jun 4, 2020
|
🎉 This PR is included in version 2.0.0-alpha.22 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The initial small icons took up 24px but the actual graphic would be limited to 16px which created a 4px space around the graphic. This made it more difficult to work with the icons, e.g. making the layout look unbalanced inside the Button with an icon. It would've also created a very breaking change for Input prefix and suffix icons.
This PR reverts the icons to 16px without spacing.
Approach and changes
Definition of done