feat(components): migrate Toggle to TypeScript #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature/typescript-toggle
This makes the props consistent with the Checkbox and RadioButton components. BREAKING CHANGE: The **Toggle** component's `on`, `labelOn`, and `labelOff` props have been renamed to `checked`, `labelChecked`, and `labelUnchecked` (🤖 _toggle-checked-prop_). feature/typescript-toggle
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/e0fol1l1k |
Codecov Report
@@ Coverage Diff @@
## beta #628 +/- ##
==========================================
- Coverage 94.25% 93.61% -0.65%
==========================================
Files 137 133 -4
Lines 2194 2192 -2
Branches 621 608 -13
==========================================
- Hits 2068 2052 -16
- Misses 103 118 +15
+ Partials 23 22 -1
|
hrstngrnvsmp
approved these changes
Jun 29, 2020
fernandofleury
approved these changes
Jun 29, 2020
feature/typescript-toggle
|
🎉 This PR is included in version 2.0.0-beta.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #516.
Approach and changes
BREAKING CHANGE:
The Toggle component's
on,labelOn, andlabelOffprops have been renamed tochecked,labelChecked, andlabelUnchecked(🤖 toggle-checked-prop).Definition of done