Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(configs): restore IE11 compatibility #640

Merged
merged 3 commits into from
Jul 17, 2020
Merged

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Jul 17, 2020

Purpose

Storybook fails to load under IE11.

Approach and changes

  • transpile all node_modules under the @sumup/* namespace
  • transpile the Storybook manager code as well, since @sumup/design-tokens is used to theme the Storybook UI
  • (unrelated) remove the prebuild step for Storybook as it's no longer needed since docs: remove test results from Storybook #621, this reduces the build and deploy times by 2-3 minutes

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@vercel
Copy link

vercel bot commented Jul 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/awaieq5wg
✅ Preview: https://circuit-ui-git-bugfix-ie11-transpile.sumup-oss.vercel.app

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #640 into beta will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             beta     #640   +/-   ##
=======================================
  Coverage   93.73%   93.73%           
=======================================
  Files         131      131           
  Lines        2236     2236           
  Branches      624      624           
=======================================
  Hits         2096     2096           
  Misses        118      118           
  Partials       22       22           

@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label Jul 17, 2020
@connor-baer connor-baer added this to the v2.0 milestone Jul 17, 2020
@connor-baer connor-baer marked this pull request as ready for review July 17, 2020 09:43
bugfix/ie11-transpile

bugfix/ie11-transpile
@connor-baer connor-baer merged commit 183b33a into beta Jul 17, 2020
@connor-baer connor-baer deleted the bugfix/ie11-transpile branch July 17, 2020 10:08
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0-beta.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants