Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename NotificationBanner component #979

Merged
merged 4 commits into from
Jun 15, 2021
Merged

Conversation

robinmetral
Copy link
Contributor

@robinmetral robinmetral commented Jun 15, 2021

Purpose

This frees up the NotificationBanner namespace for v3.x. We will later deprecate the Notification, NotificationList and NotificationCard components in favor of the upcoming NotificationToast, NotificationBanner, NotificationFullscreen and NotificationModal components.

Approach and changes

  • Rename all instances of NotificationBanner into NotificationCard
  • Add codemod (shamelessly copied over from the v2 component renames codemod)

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2021

🦋 Changeset detected

Latest commit: 55993ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/HwPqUDRH4Dcgyds9RSF1FYgmWoAN
✅ Preview: https://oss-circuit-ui-git-rename-notificationbanner-sumup.vercel.app

@sumup-clark
Copy link

sumup-clark bot commented Jun 15, 2021

Hey @robinmetral,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #979 (55993ac) into next (1a1a364) will increase coverage by 0.01%.
The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #979      +/-   ##
==========================================
+ Coverage   91.66%   91.68%   +0.01%     
==========================================
  Files         164      165       +1     
  Lines        3061     3077      +16     
  Branches      781      782       +1     
==========================================
+ Hits         2806     2821      +15     
- Misses        226      227       +1     
  Partials       29       29              
Impacted Files Coverage Δ
...kages/circuit-ui/cli/migrate/component-names-v3.ts 93.75% <93.75%> (ø)
...i/components/NotificationCard/NotificationCard.tsx 100.00% <100.00%> (ø)

'@sumup/circuit-ui': major
---

Rename NotificationBanner component into NotificationCard.
Copy link
Member

@connor-baer connor-baer Jun 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd mention that we plan to deprecate it in the future (similar to what you wrote in the PR description).

Suggested change
Rename NotificationBanner component into NotificationCard.
Renamed the NotificationBanner component to NotificationCard.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 55993ac

@robinmetral robinmetral enabled auto-merge (squash) June 15, 2021 12:25
@robinmetral robinmetral merged commit 3cfefac into next Jun 15, 2021
@robinmetral robinmetral deleted the rename-notificationbanner branch June 15, 2021 12:45
@github-actions github-actions bot mentioned this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants