-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notification modal #994
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/5qWPLKCHZwZzUD5cJxEim6j9crSG |
🦋 Changeset detectedLatest commit: 15bcff7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
a318d72
to
ab7d85d
Compare
Codecov Report
@@ Coverage Diff @@
## main #994 +/- ##
==========================================
+ Coverage 91.80% 91.84% +0.04%
==========================================
Files 180 182 +2
Lines 3454 3484 +30
Branches 1081 1091 +10
==========================================
+ Hits 3171 3200 +29
Misses 266 266
- Partials 17 18 +1
|
ab7d85d
to
7c4f270
Compare
7c4f270
to
d164456
Compare
packages/circuit-ui/components/NotificationModal/NotificationModal.docs.mdx
Outdated
Show resolved
Hide resolved
packages/circuit-ui/components/NotificationModal/NotificationModal.docs.mdx
Outdated
Show resolved
Hide resolved
packages/circuit-ui/components/NotificationModal/NotificationModal.docs.mdx
Outdated
Show resolved
Hide resolved
packages/circuit-ui/components/NotificationModal/NotificationModal.docs.mdx
Outdated
Show resolved
Hide resolved
packages/circuit-ui/components/NotificationModal/NotificationModal.docs.mdx
Outdated
Show resolved
Hide resolved
packages/circuit-ui/components/NotificationModal/NotificationModal.stories.tsx
Outdated
Show resolved
Hide resolved
packages/circuit-ui/components/NotificationModal/NotificationModal.stories.tsx
Outdated
Show resolved
Hide resolved
packages/circuit-ui/components/NotificationModal/NotificationModal.tsx
Outdated
Show resolved
Hide resolved
packages/circuit-ui/components/NotificationModal/NotificationModal.tsx
Outdated
Show resolved
Hide resolved
packages/circuit-ui/components/NotificationModal/NotificationModal.spec.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't approve because I opened the PR, but you can take this comment as approval 👍🏻👏🏻
🔔⬜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions along with my approval because I probably missed some discussions during the implementation of this component, and I'm interested 🙂
Addresses #792.
Purpose
Introduces the new NotificationModal component.
Notification modal component communicates critical information, and needs the user's attention or action to proceed.
Approach and changes
Refer to the Storybook for further implementation and usage guidelines, and to the threads below for more details and discussion on the implementation.
Definition of done