Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the typography-sizes changeset to transform Anchors #998

Merged
merged 6 commits into from
Jun 25, 2021

Conversation

robinmetral
Copy link
Contributor

@robinmetral robinmetral commented Jun 23, 2021

Purpose

We overlooked the Anchor in the typography-sizes codemod for V3: it should be migrated just like Body, because it extends its props.

Approach and changes

  • Update the codemods and fixtures
    • Support Anchors
    • Warn for headline zetta sizes and body giga sizes that a manual migration is necessary
  • Update the changelog

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@robinmetral robinmetral requested a review from a team as a code owner June 23, 2021 16:40
@robinmetral robinmetral requested review from amelako and removed request for a team June 23, 2021 16:40
@vercel
Copy link

vercel bot commented Jun 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/6pHmgK7YUsa9aLmPqYvgpi48FF4R
✅ Preview: https://oss-circuit-ui-git-typography-codemod-fixes-sumup.vercel.app

@sumup-clark
Copy link

sumup-clark bot commented Jun 23, 2021

Hey @robinmetral,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #998 (4a03c40) into next (62826bc) will increase coverage by 0.02%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #998      +/-   ##
==========================================
+ Coverage   90.96%   90.99%   +0.02%     
==========================================
  Files         160      160              
  Lines        2646     2665      +19     
  Branches      763      765       +2     
==========================================
+ Hits         2407     2425      +18     
- Misses        214      215       +1     
  Partials       25       25              
Impacted Files Coverage Δ
...ackages/circuit-ui/cli/migrate/typography-sizes.ts 93.47% <94.44%> (+0.62%) ⬆️
...s/circuit-ui/cli/migrate/body-variant-highlight.ts 95.00% <100.00%> (+0.26%) ⬆️

@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2021

🦋 Changeset detected

Latest commit: 4a03c40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@robinmetral robinmetral changed the title Add missing cases to the typography codemods Extend the typography-sizes changeset to transform Anchors Jun 25, 2021
Copy link
Contributor

@amelako amelako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@robinmetral robinmetral merged commit 43b1403 into next Jun 25, 2021
@robinmetral robinmetral deleted the typography-codemod-fixes branch June 25, 2021 11:15
@github-actions github-actions bot mentioned this pull request Jun 25, 2021
This was referenced Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants