This repository has been archived by the owner on Jan 11, 2021. It is now read-only.
Support FixedLenByteArrayType in DeltaByteArrayEncoder #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for FixedLenByteArrayType in DeltaByteArrayEncoder. The implementation basically reuses the code from ByteArrayType. Fixes #95.
sadikovi
approved these changes
Apr 29, 2018
| @@ -815,13 +819,13 @@ impl<> Decoder<ByteArrayType> for DeltaByteArrayDecoder<ByteArrayType> { | |||
| assert!(self.suffix_decoder.is_some()); | |||
|
|
|||
| let num_values = cmp::min(buffer.len(), self.num_values); | |||
| let mut v: [ByteArray; 1] = [ByteArray::new(); 1]; | |||
| @@ -842,6 +846,17 @@ impl<> Decoder<ByteArrayType> for DeltaByteArrayDecoder<ByteArrayType> { | |||
| } | |||
| } | |||
|
|
|||
| impl<> Decoder<FixedLenByteArrayType> for DeltaByteArrayDecoder<FixedLenByteArrayType> { | |||
| fn set_data(&mut self, data: ByteBufferPtr, num_values: usize) -> Result<()> { | |||
| let s: &mut DeltaByteArrayDecoder<ByteArrayType> = unsafe { mem::transmute(self) }; | |||
There was a problem hiding this comment.
That is an interesting approach!
|
Hmm yes. It happened again. Will investigate. |
|
Merged. Thanks @sadikovi ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for FixedLenByteArrayType in DeltaByteArrayEncoder.
The implementation basically reuses the code from ByteArrayType.
Fixes #95.