This repository has been archived by the owner on Jan 11, 2021. It is now read-only.
Support unsigned types and timestamp millis in record reader #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 645
💛 - Coveralls |
|
Merged. Thanks @sadikovi ! |
|
Thanks! It is not the best change, but I could not find better names for the new types. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the following logical types for the record reader API:
I named the new fields as UByte, UShort, UInt and ULong. I know, these names are not the best, but I can't change the existing API to make them all conform to either INT_XY or UINT_XY.
I also updated accessors' methods and updated unit tests.
Relates to #178.