Rename invalid_mut to without_provenance_mut
#123
Conversation
|
OK @sunfishcode I've setup the CI on my own fork and it's working good! Unfortunately, c-scape and c-gull have trouble selecting the correct |
…the various feature changes introduced by origin `0.18.x`
|
@sunfishcode now everything should be fixed! The CI passes every platform and all tests pass as expected. Note that I bumped the crate version since origin 0.18 changed some features that were reflected in some changes to the |
c-scape/Cargo.toml
Outdated
| @@ -64,7 +64,7 @@ static_assertions = "1.1.0" | |||
|
|
|||
| [features] | |||
| default = ["thread", "std", "coexist-with-libc", "threadsafe-setenv", "use-compiler-builtins"] | |||
| thread = ["origin/set_thread_id"] | |||
| thread = [] # set_thread_id is not behind a feature anymore. | |||
There was a problem hiding this comment.
Reading this comment from the perspective of someone new to the codebase, this comment comes across as "this thing you haven't heard of doesn't exist anymore" ;-). While comments are good in general, I think we can just leave this one out.
There was a problem hiding this comment.
Ok, I'll delete the comment then
Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "c-ward" | |||
| version = "0.15.40" | |||
There was a problem hiding this comment.
Here and in the other Cargo.toml files, it's not necessary to bump the version number; I use cargo release to do the releases, which will do the bump automatically.
There was a problem hiding this comment.
oh ok, i'll then revert the changes
|
@sunfishcode everything should be fixed now! |
|
Thanks! |
Fixes #122
NOTE: Also Origin needs these changes apparently.