Skip to content

Commit

Permalink
Dont expect indices in validation messages either.
Browse files Browse the repository at this point in the history
Similar to WebAssembly#1076, don't include index numbers in expected error messages
from validation. This allows implementations to avoid creating
dynamically formatted strings for validation error messages. Admittedly
this isn't a huge burden, but it does seem like something that shouldn't
be required to pass the spec test.
  • Loading branch information
sunfishcode committed Oct 7, 2019
1 parent 5e3277c commit 0251ae9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion test/core/call_indirect.wast
Original file line number Diff line number Diff line change
Expand Up @@ -938,5 +938,5 @@

(assert_invalid
(module (table funcref (elem 0 0)))
"unknown function 0"
"unknown function"
)
2 changes: 1 addition & 1 deletion test/core/data.wast
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@
(module
(data (i32.const 0) "")
)
"unknown memory 0"
"unknown memory"
)

;; Invalid offsets
Expand Down
2 changes: 1 addition & 1 deletion test/core/elem.wast
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@
(func $f)
(elem (i32.const 0) $f)
)
"unknown table 0"
"unknown table"
)

;; Invalid offsets
Expand Down

0 comments on commit 0251ae9

Please sign in to comment.