New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use signed integers for enums instead of unsigned integers #11

Merged

sunny-g merged 1 commit into sunny-g:master from bryanjos:negative-numbers

Jun 7, 2018

Contributor

bryanjos commented Jun 5, 2018

Some of the enums in the stellar xdr definitions have negative values in the enums. I was getting an error about "all enum values must be numbers" when I tried to use negative numbers.

This PR updates that check to look for negative number AST and also makes it so Enum uses Int instead of Uint to decode and encode values:


          Use signed integers for enums instead of unsigned integers

5e4352f

sunny-g merged commit 53c6c6d into sunny-g:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet