Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to kubectl plugin kc #503

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Conversation

astraw99
Copy link
Contributor

Hi sunny0826,
This is an awesome tool! Thanks for your open source contribution :)
It helps us to manage kubeconfig more efficiently.

I submitted a PR kubernetes-sigs/krew-index#2545 to add this tool to krew.
To make this tool to broader users.

Signed-off-by: astraw99 <wangchengiscool@gmail.com>
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #503 (d9e8e77) into master (2de01d0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #503   +/-   ##
=======================================
  Coverage   11.53%   11.53%           
=======================================
  Files          19       19           
  Lines        1846     1846           
=======================================
  Hits          213      213           
  Misses       1616     1616           
  Partials       17       17           
Flag Coverage Δ
unittests 11.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Owner

@sunny0826 sunny0826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, the file .krew.yaml is supposed to be a template file, like this https://github.com/rajatjindal/kubectl-evict-pod/blob/main/.krew.yaml

You can refer to https://github.com/rajatjindal/krew-release-bot

Signed-off-by: astraw99 <wangchengiscool@gmail.com>
@astraw99
Copy link
Contributor Author

As far as I know, the file .krew.yaml is supposed to be a template file, like this https://github.com/rajatjindal/kubectl-evict-pod/blob/main/.krew.yaml

You can refer to https://github.com/rajatjindal/krew-release-bot

Got it, updated.
Please help to add the krew-release-bot action.
PTAL thanks.

Copy link
Owner

@sunny0826 sunny0826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunny0826
Copy link
Owner

Thanks for your contribution

@sunny0826 sunny0826 merged commit 9468853 into sunny0826:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants