Fix delete removes user even if another context is using it
#837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a check to make sure that we don't delete a user or a cluster that is in use by another context than the one getting deleted. I also added a unit test that deletes a context that references a user that is referenced within another context. Signed-off-by: Yarden Shoham <git@yardenshoham.com>
|
The Label Bot has predicted the following:
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #837 +/- ##
==========================================
+ Coverage 18.62% 19.18% +0.56%
==========================================
Files 20 20
Lines 2201 2220 +19
==========================================
+ Hits 410 426 +16
- Misses 1752 1754 +2
- Partials 39 40 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks a lot ! I will finish the Review as soon as possible |
sunny0826
approved these changes
Jan 8, 2024
|
@all-contributors please add @yardenshoham for test. |
|
I've put up a pull request to add @yardenshoham! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a check to make sure that we don't delete a user or a cluster that is in use by another context than the one getting deleted.
I also added a unit test that deletes a context that references a user that is referenced within another context.