-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing issue #888 #967
fixing issue #888 #967
Conversation
The Label Bot has predicted the following:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #967 +/- ##
==========================================
+ Coverage 19.68% 20.56% +0.88%
==========================================
Files 21 21
Lines 2134 2164 +30
==========================================
+ Hits 420 445 +25
- Misses 1670 1673 +3
- Partials 44 46 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, just need to add some unit tests.
@sunny0826 done.. |
yep, there is no need to add e2e test to this bug fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for your valuable contribution to this project! Your work is greatly appreciated. 🎆
Description
fixing #888
Related Issue
Type of Change
Checklist
make build
andmake test
commands.make doc-gen
to generate new documentation.