Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add KUBECM_DISABLE_K8S_MORE_INFO env to disable output moreinfo #973

Conversation

yxxhero
Copy link
Contributor

@yxxhero yxxhero commented Jun 11, 2024

Description

Related Issue

resolves #972

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes only affecting documentation)

Checklist

  • I have tested my changes locally and ensured they are functioning properly. Please run the make build and make test commands.
  • I have added/updated unit or e2e tests to cover my changes.
  • I have updated the relevant documentation. If you change commands or arguments, run make doc-gen to generate new documentation.

Signed-off-by: yxxhero <aiopsclub@163.com>
@the-label-bot the-label-bot bot added kind/feature ategorizes issue or PR as related to a new feature. size/XS size/XS labels Jun 11, 2024
Copy link

the-label-bot bot commented Jun 11, 2024

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind feature 0.735 ✔️
Size XS 0.991 ✔️

@yxxhero
Copy link
Contributor Author

yxxhero commented Jun 11, 2024

@sunny0826 WTDY? I am yuanXiongXiong.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 20.53%. Comparing base (561e01c) to head (f1d2bc2).

Files Patch % Lines
cmd/list.go 0.00% 3 Missing ⚠️
cmd/utils.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
- Coverage   20.56%   20.53%   -0.03%     
==========================================
  Files          21       21              
  Lines        2164     2167       +3     
==========================================
  Hits          445      445              
- Misses       1673     1675       +2     
- Partials       46       47       +1     
Flag Coverage Δ
unittests 20.53% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@sunny0826 sunny0826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a description of this environment variable to listExample().

Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero yxxhero requested a review from sunny0826 June 11, 2024 06:55
Copy link
Owner

@sunny0826 sunny0826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for your valuable contribution to this project! Your work is greatly appreciated. 🎆

@sunny0826 sunny0826 merged commit bd19760 into sunny0826:master Jun 11, 2024
6 checks passed
@sunny0826
Copy link
Owner

@all-contributors please add @yxxhero for code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature ategorizes issue or PR as related to a new feature. size/XS size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to disable output [Summary] Namespace: 43 Node: 23 Pod: 705
2 participants