Fix error in helioviewer if download dir does not exist #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @vn-ki! Thanks for updating the PR.
Comment last updated on May 29, 2018 at 10:10 Hours UTC |
vn-ki
commented
May 25, 2018
sunpy/net/tests/test_helioviewer.py
Outdated
| instrument='MDI', | ||
| detector='MDI', | ||
| measurement='continuum', | ||
| directory='/') |
There was a problem hiding this comment.
Would this be a problem on windows machines?
There was a problem hiding this comment.
yeah probably. you could use os.path.sep but I don't think \ exists on windows either...
Cadair
reviewed
May 25, 2018
sunpy/net/tests/test_helioviewer.py
Outdated
| instrument='MDI', | ||
| detector='MDI', | ||
| measurement='continuum', | ||
| directory='directorynotexist') |
There was a problem hiding this comment.
can you make this inside a tmp dir so it's not related to the path of this code? pytest has a global tmpdir fixture, and then this line should be os.path.join('tmpdir', 'directorynotexist')
Cadair
approved these changes
May 30, 2018
Cadair
added
[BugFix]
Affects Release
|
this is missing a changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.