-
-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several DeprecationWarning: invalid escape sequence #2885
Conversation
Signed-off-by: Mickaël Schoentgen <contact@tiger-222.fr>
Hello @BoboTiG! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on January 05, 2019 at 21:09 Hours UTC |
Thanks for the pull request @BoboTiG! Everything looks great! |
Do you want me to open a new PR for flake8 fixes? They are not related to my changes but still I can do that work separately :) |
Hi @BoboTiG , you are referring to the Also you referring to the pep8 issues that @pep8speaks reported? |
I was referring to the pep8 issues that @pep8speaks reported. I will open a new PR for those specific fixes. |
I mean't the focus of the changes you've made in this PR? Also I would be against a separate PR only for pep8 fixes. |
Oh OK :) Changes in this PR are related to general Python code, not specifically about what the documentation build reported. |
If you want to do pep8 fixes, I would suggest doing them in this PR. Can you check that these errors are gone in the documentation build ( |
OK for PEP8 fixes, will do in that PR. About doc build: the number of such warnings went from 33 to 5. I need to track the last ones. |
OK, fixed all PEP8 errors. For errors reported from docstrings code, I did not want to break anything so I disabled checks using the The 5 remaining invalid sequences was inside a |
Thank you very much @BoboTiG! |
My pleasure :) |
Description
Fixes all
DeprecationWarning: invalid escape sequence
:)