Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several DeprecationWarning: invalid escape sequence #2885

Merged
merged 13 commits into from
Jan 7, 2019
Merged

Fix several DeprecationWarning: invalid escape sequence #2885

merged 13 commits into from
Jan 7, 2019

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Jan 5, 2019

Description

Fixes all DeprecationWarning: invalid escape sequence :)

Signed-off-by: Mickaël Schoentgen <contact@tiger-222.fr>
@pep8speaks
Copy link

pep8speaks commented Jan 5, 2019

Hello @BoboTiG! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on January 05, 2019 at 21:09 Hours UTC

@ghost
Copy link

ghost commented Jan 5, 2019

Thanks for the pull request @BoboTiG! Everything looks great!

@BoboTiG
Copy link
Contributor Author

BoboTiG commented Jan 5, 2019

Do you want me to open a new PR for flake8 fixes? They are not related to my changes but still I can do that work separately :)

@nabobalis
Copy link
Contributor

Hi @BoboTiG , you are referring to the invalid escape sequence in our documentation build?

Also you referring to the pep8 issues that @pep8speaks reported?

@BoboTiG
Copy link
Contributor Author

BoboTiG commented Jan 5, 2019

I was referring to the pep8 issues that @pep8speaks reported. I will open a new PR for those specific fixes.

@nabobalis
Copy link
Contributor

I mean't the focus of the changes you've made in this PR?

Also I would be against a separate PR only for pep8 fixes.

@BoboTiG
Copy link
Contributor Author

BoboTiG commented Jan 5, 2019

Oh OK :)

Changes in this PR are related to general Python code, not specifically about what the documentation build reported.
Those DeprecationWarnings are already converted to SyntaxWarnings in the current Python dev branch and will become SyntaxError in a near future version.

@nabobalis
Copy link
Contributor

If you want to do pep8 fixes, I would suggest doing them in this PR.

Can you check that these errors are gone in the documentation build (ci/circleci: html-docs)?

@nabobalis nabobalis added this to the 1.0 milestone Jan 5, 2019
@BoboTiG
Copy link
Contributor Author

BoboTiG commented Jan 5, 2019

OK for PEP8 fixes, will do in that PR.

About doc build: the number of such warnings went from 33 to 5. I need to track the last ones.

@BoboTiG
Copy link
Contributor Author

BoboTiG commented Jan 5, 2019

OK, fixed all PEP8 errors. For errors reported from docstrings code, I did not want to break anything so I disabled checks using the noqa comment.

The 5 remaining invalid sequences was inside a .rst file. There is now no more such warning in the documenation build :)

@nabobalis nabobalis merged commit d717dcc into sunpy:master Jan 7, 2019
@nabobalis
Copy link
Contributor

Thank you very much @BoboTiG!

@BoboTiG BoboTiG deleted the fix-invalid-seq-warnings branch January 7, 2019 16:47
@BoboTiG
Copy link
Contributor Author

BoboTiG commented Jan 7, 2019

My pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants